search

benlucchesi / grails-cookie-session

cookie sessions for grails applications
28 stars 32 forks source link

support for withForm #48

Open benlucchesi opened 9 years ago

benlucchesi commented 9 years ago

It looks like the object used to hold keys used by the withForm method isn't serializable and is getting dropped from the session object. either that or the object isn't getting written to/read from the session before or after the cookie session is loaded. need to investigate.

exell-christopher commented 9 years ago

We were testing out this plugin as a replacement for container based sessions, but ran into the same withForm issue. The form token appears to be added to the session after render is called as it's generated in the gsp. Because the gsp is rendered after grails has set the status on the request, there is no chance to capture further changes to the session, and write out the new cookies. I have a fix for this that I'll do a pull request for shortly.

benlucchesi commented 9 years ago

great. that will be much appreciated. looking forward to it.

benlucchesi commented 9 years ago

hey exell-christopher,

were you able to test your changes with the test-suite as described in the response to your pull request?

-ben

exell-christopher commented 9 years ago

I haven't had a chance to get back to this yet. Hoping to sometime this week.

On Mon, Apr 13, 2015 at 10:32 AM, Ben Lucchesi notifications@github.com wrote:

hey exell-christopher,

were you able to test your changes with the test-suite as described in the response to your pull request?

-ben

— Reply to this email directly or view it on GitHub https://github.com/benlucchesi/grails-cookie-session-v2/issues/48#issuecomment-92440564 .

double16 commented 6 years ago

Fixed in https://github.com/double16/grails-cookie-session/tree/release/4.0.0

dependencies { compile 'org.grails.plugins:cookie-session:4.0.0.RC1' }