search

benlucchesi / grails-cookie-session

cookie sessions for grails applications
28 stars 32 forks source link

Fix for withForm bug #51

Open exell-christopher opened 9 years ago

benlucchesi commented 9 years ago

Hi Christopher,

Thanks for the fix. At first blush, I don't see a problem with the code, but I am concerned about the number of times the session gets written and when it can be written. If the session is written an excessive number of times, it impacts performance significantly. Also, if it gets written more than once into the response, then it runs the risk of changing size and overwriting other data in the response.

Can you do me a solid and checkout the repo: https://github.com/benlucchesi/test-cookie-session-plugin There are two branches of interest: springsecurity2.0 and springsecurity1.0. This project is a test suite for the cookie session plugin and these branches test it with two version of spring security.

To launch the test suite use: grails test-app --https :spock

This will launch integration and functional tests. The functional tests use the firefox selenium drive so you'll need firefox installed.

You may need to add or configure logging to detect how and when the session gets written. There isn't a test specifically for this condition, but if there is a problem, hopefully something breaks.

thanks, -ben

exell-christopher commented 9 years ago

Haven't had a chance to dig into testing this against the test harnesses. If someone has time, and wants to give it a shot it would be appreciated.

benlucchesi commented 9 years ago

I'll check it out soon. On May 16, 2015 9:24 AM, "exell-christopher" notifications@github.com wrote:

Haven't had a chance to dig into testing this against the test harnesses. If someone has time, and wants to give it a shot it would be appreciated.

— Reply to this email directly or view it on GitHub https://github.com/benlucchesi/grails-cookie-session-v2/pull/51#issuecomment-102647171 .

double16 commented 6 years ago

Merged into https://github.com/double16/grails-cookie-session/tree/release/4.0.0