benluteijn / cherokee

Automatically exported from code.google.com/p/cherokee
0 stars 1 forks source link

[Admin] Fix the out of screen position of closed tabs #164

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Go to your favorite directory/extension
2. Click on Rule
3. Notice that the reset of the 'tabs' are invisible, unless you scroll down

Original issue reported on code.google.com by ste...@konink.de on 28 Oct 2008 at 9:38

GoogleCodeExporter commented 9 years ago
They're not invisible if you have a big screen. <:o)

No, seriously. This is a usability issue that has been bugging me since day 
one. I
never figured out how to auto-resize the height of the tabs with jQuery's 
Accordion
plugin, which is what is in use right now.

Original comment by tah...@gmail.com on 28 Oct 2008 at 12:15

GoogleCodeExporter commented 9 years ago
I think it's fixed in r2226.

Test, please.

Original comment by skar...@gmail.com on 28 Oct 2008 at 5:31

GoogleCodeExporter commented 9 years ago
My tests are working so far.
I can't believe it was so simple. I could have sworn I tried that parameter a
thousand times.

Skarcha, good job.
You can close the bug whenever you like.

Original comment by tah...@gmail.com on 28 Oct 2008 at 6:52

GoogleCodeExporter commented 9 years ago
Thanks :) Works for me.

Original comment by ste...@konink.de on 28 Oct 2008 at 7:40

GoogleCodeExporter commented 9 years ago
Just for the record... From jquery.accordion.js:

@option Boolean autoheight If set, the highest content part is used as height
reference for all other parts. Provides more consistent animations. Default: 
false

So all tabs had the height of the bigger tab.

Original comment by skar...@gmail.com on 28 Oct 2008 at 8:01

GoogleCodeExporter commented 9 years ago
Congrats skarcha.. great stuff!! :-)

Original comment by alobbs on 28 Oct 2008 at 8:59