search

benlye / flash-multi

A tool for managing the firmware on a MULTI-Module
GNU General Public License v3.0
91 stars 28 forks source link

Google Safe Browsing Blocking releases #16

Closed harking closed 4 years ago

harking commented 4 years ago

Tried to access the releases page and ran into this: https://transparencyreport.google.com/safe-browsing/search?url=https:%2F%2Fgithub.com%2Fbenlye%2Fflash-multi%2Freleases&hl=en-US

benlye commented 4 years ago

Ugh, that's great. Fixing this might be very difficult because it requires proving ownership of the site, and there's no way to do that with Github.

I suspect it's probably triggered by the driver installers which are in the downloads, but they are completely safe and only run when the user selects them.

VirtualEnder commented 4 years ago

Windows is actually registering this file as a trojan. image

benlye commented 4 years ago

Sigh. This has happened before. Fortunately Microsoft are actually decent and provide a way that normal human beings can get them to re-assess the package. I've submitted it to them to take a look at and hopefully it will be unblocked in the next Windows Defender signature update. Normally they turn it around quickly.

I wish I could work out what the cause of all this is. The installer and app really don't do anything that could be construed as malicious. The installer does install drivers, but so do many other software packages.

benlye commented 4 years ago

After a little bit more digging, it seems like the most likely culprit is wdi-simple.exe, which is the installer for the Maple USB drivers. It's another open source package on Github: https://github.com/pbatard/libwdi/blob/master/examples/wdi-simple.c

Scanning the compiled wdi-simple.exe file on VirusTotal gives all the same erroneous warnings as the Flash Multi package.

I guess I'll start looking for an alternative way to install the Maple drivers.

benlye commented 4 years ago

I'm going to try removing the Windows installer downloads from the releases to see if that helps with the Google Safe Browsing issue. I don't know if it will, or if Google will even re-scan the site in order to detect the change.

In the meantime I have mirrored the repository to an new one, and will not be attaching the executable installers in an attempt to see if that is the problem.

Please go to this repository to download the latest version of Flash Multi: https://github.com/benlye/flashmulti/releases

benlye commented 4 years ago

It seems like removing the executable installers has fixed the issue with Google safe browsing :-)

I'll remove the cloned repo.

benlye commented 4 years ago

Hopefully we've seen the last of this!

github-actions[bot] commented 2 years ago

This issue has been automatically locked because there was no further activity after it was closed. Please open a new issue for any related problems.