search

benma / visual-regexp.el

A regexp/replace command for Emacs with interactive visual feedback
396 stars 28 forks source link

A few little tweaks #1

Closed purcell closed 11 years ago

purcell commented 11 years ago

Hi! Here are a couple of little changes you might like to incorporate. The biggest is to switch from cl to cl-lib: it mostly just affects the namespace of related functions and macros. cl-lib is part of emacs 24, and a backwards-compatible package is provided in GNU ELPA for Emacs 23. :-)

purcell commented 11 years ago

You know, I probably should have added an ;;;###autoload comment for vr/query-replace too... doh!

benma commented 11 years ago

Thanks a lot. I reverted to cl because the function multiple-value-bind is not defined in cl-lib. Would you happen to know if something analogous exists in cl-lib?

purcell commented 11 years ago

Yes, it's just cl-multiple-value-bind -- that's one of the changes I made in d4367547ce0.

benma commented 11 years ago

Ah, the error must have originated from visual-regexp-steroids then. I will modify it and move to cl-lib again. Btw., do you think you will be using this package? If so, I would appreciate feedback / suggestions etc. once you could field test it for a while.

purcell commented 11 years ago

If by "this package" you mean visual-regexp, then yes! I just started to try it out, and that's what made me want to add the autoloads. I really like it. But if you mean visual-regexp-steroids, I haven't looked at that yet. :-)

benma commented 11 years ago

Yeah, I meant visual-regexp. The steroids package is the same, but with external scripts to enable modern regexp engines (in vr/query-replace as well as emacs regexp isearch).

purcell commented 11 years ago

I was just taking a look -- it also looks cool. Good work!

benma commented 11 years ago

Thanks!