Fix #26 - Githubissues

benma / visual-regexp.el

A regexp/replace command for Emacs with interactive visual feedback

392 stars 28 forks source link

Fix #26 #27

Closed syohex closed 9 years ago

syohex commented 9 years ago

check whether element of match-data is nil
convert symbol to string for avoiding exception of mapconcat

This is related to #26.

benma commented 9 years ago

Thanks so much for tracking it down. It is weird that (match-data) can have nil entries. Not sure how that can make sense (edit: figured it out, they are nil when it is an optional group, i.e. $...$?).

Please remove your first commit ("Use symbol name if argument is symbol"), since that is applying the fix at the wrong place. Please put this commit into your PR instead: https://github.com/benma/visual-regexp.el/commit/6d903e76c0cff489eb592493d5ac2e69c66a310c

syohex commented 9 years ago

Done. @benma Please check.

benma commented 9 years ago

Good work. thanks! :dancers:

@syohex $1 @changetip

changetip commented 9 years ago

Hi @syohex, @benma sent you a Bitcoin tip worth 4,092 bits ($1.00), and I'm here to deliver it ➔ collect your tip.

Learn more about ChangeTip