search

benma / visual-regexp.el

A regexp/replace command for Emacs with interactive visual feedback
392 stars 28 forks source link

Show previous history keybinding in help text #38

Closed jacktasia closed 8 years ago

jacktasia commented 8 years ago

As mentioned in #15

benma commented 8 years ago

Thanks. I don't think this necessary though, as going back in history is a normal Emacs minibuffer feature and not related to visual regexp.

next-history-element, isearch-backward, and the many other bindings are also not in the visual regexp help text, after all.

Thoughts?

jacktasia commented 8 years ago

I don't think this necessary

I don't think it's necessary exactly, but it's clearly somewhat of a problem since #15 exists. visual-regexp.el is awesome, but I had come to count on the defaulting to the last search/replace like query-replace-regexp.

as going back in history is a normal Emacs minibuffer feature and not related to visual regexp

This is just a nice reminder of what's possible since emacs is huge and a lot of people use helm things for things that were traditionally minibuffer only...so they may not know about this functionality. For instance, I've used emacs for 7 years and have made a kind of popular emacs plugin and I didn't know I could do this until I saw #15.

and the many other bindings are also not in the visual regexp help text

That's true and I totally understand if you don't merge this, but I feel like this is particularly important functionality to point out since it saves so much time.

So those are my thoughts 😄

benma commented 8 years ago

Sorry for the long wait. I am on board with your pragmatic approach :) I assumed that basically everybody knew that you can go back in history in the minibuffer, because it is so similar to a linux shell line, and every linux shell supports arrow-up and C-r to browse the history.