search

benma / visual-regexp.el

A regexp/replace command for Emacs with interactive visual feedback
392 stars 28 forks source link

Fix some byte-compiler and check-doc warnings. #61

Closed twmr closed 3 years ago

twmr commented 3 years ago

This doesn't fix all byte compiler warnings but it is a start.

What remains to be fixed are the following warnings:

visual-regexp.el:105:18: Warning: defcustom for
    ‘query-replace-from-to-separator’ fails to specify containing group

In vr/mc-mark:
visual-regexp.el:795:48: Warning: misplaced interactive spec: ‘(interactive
    (vr--interactive-get-args 'vr--mode-regexp 'vr--calling-func-mc-mark))’

In end of data:
visual-regexp.el:819:6: Warning: the function ‘mc/maybe-multiple-cursors-mode’
    is not known to be defined.
visual-regexp.el:818:10: Warning: the function ‘mc/pop-state-from-overlay’ is
    not known to be defined.
visual-regexp.el:811:77: Warning: the function
    ‘mc/create-fake-cursor-at-point’ is not known to be defined.
visual-regexp.el:797:6: Warning: the function ‘mc/remove-fake-cursors’ is not
    known to be defined.
twmr commented 3 years ago

@benma there are currently three open PRs in your repo. Could it be that you overlooked them, since there is no comment from you in those PRs.

benma commented 3 years ago

@benma there are currently three open PRs in your repo. Could it be that you overlooked them, since there is no comment from you in those PRs.

Thanks for your contribution!

I saw them, but unfortunately I have very little time these days, so it is hard to find time to work on this project.

twmr commented 3 years ago

I've seen that you have recently been active on github and assumed that you weren't notified of the "new" PRs in this repo, because it happened to me as well that I wasn't notified of PRs in one of my own repos. Thx a lot for finding the time to respond to my comment!