search

benmajor / jQuery-Touch-Events

A collection of mobile event plugins for jQuery.
MIT License
699 stars 225 forks source link

Correct naming of mouse vents on Github README #90

Closed dragGH102 closed 8 years ago

dragGH102 commented 8 years ago

May I suggest to use the correct name for javascript event in section 4. The event? (since it's basically what's written in the plug-in JS file)

   [mobile --> desktop]
   tapstart --> mousedown (instead of 'clicking' which is misleading)
   tapend --> mouseup

. ...and so on...

I believe it would be clearer and quicker to understand for an inexperienced developer

benmajor commented 8 years ago

I'm not sure that I follow your suggestion? This library triggers its own events, which have their own names.

The event that the library triggers called tap isn't the same as a native click event, and similarly tapstart != mousedown...

dragGH102 commented 8 years ago

I mean that where you specify the corresponding event on desktop , specifying its actual name would be better rather than just a "non for dev" explanation (e.g. Click in tapstart line)

-----Original Message----- From: "Ben Major" notifications@github.com Sent: ‎11/‎19/‎2015 9:12 PM To: "benmajor/jQuery-Touch-Events" jQuery-Touch-Events@noreply.github.com Cc: "Manuel" gajo.manuel@gmail.com Subject: Re: [jQuery-Touch-Events] Correct naming of mouse vents on GithubREADME (#90)

I'm not sure that I follow your suggestion? This library triggers its own events, which have their own names. The event that the library triggers called tap isn't the same as a native click event, and similarly tapstart != mousedown... — Reply to this email directly or view it on GitHub.

benmajor commented 8 years ago

Can you provide an example? Do you just mean an update to the README, or something more?

dragGH102 commented 8 years ago

on github repository's 'code' tab (new layout) 

4. The Events:
    tapstart  Fired as soon as the user begins touching an element (or clicking, for desktop environments).

but 'clicking' (click) != 'mousedown'

this can be misleading in my opinion

also, a typo:

 in conjunction without tap events,

with tap

benmajor commented 8 years ago

Hm, I don't think it's so misleading. Taking out the parentheses, mousedown does represent the action when a user begins clicking.

Thanks for the heads-up on the typo, though!