search

benmanns / goworker

goworker is a Go-based background worker that runs 10 to 100,000* times faster than Ruby-based workers.
https://www.goworker.org
Other
2.79k stars 241 forks source link

Any plans to support Sidekiq backend? #47

Open harlow opened 7 years ago

harlow commented 7 years ago

Not sure if this is on the radar, but has any thought gone into supporting Sidekiq too?

rjrobinson commented 7 years ago

I was visiting this idea as well. But kind of make it for active job.

benmanns commented 7 years ago

I would be interested in fully supporting Sidekiq. I'm more familiar with the insides of Resque than Sidekiq, but I believe they are similar (at least standard enqueue/dequeue). Do you know what features would need to be implemented for compatibility?

harlow commented 7 years ago

Do you know what features would need to be implemented for compatibility?

@benmanns will take a look this week; @rjrobinson maybe ActiveJob is better interface to build against (assuming it works w/ sidekiq)?

We're heavy Ruby/Sidekiq users and beginning to port a few of them to Go. Would def be interested in helping out if it's something that would fit nicely into this project.

rjrobinson commented 7 years ago

ActiveJob has sidekiq support ( thats what I use.) . Let me dig a little deeper.

tbh.... we could just build out our own go version of a background service, that takes in json from redis.

I was always confused why go-worker took in an interface of interfaces. Seems like a json payload, and then marshaling it to a struct was a easier choice