search

benmarch / angular-bootstrap-tour

AngularJS wrapper around Bootstrap Tour
64 stars 27 forks source link

Fix attaching template sourced form 'template-url' #19

Closed selvach closed 9 years ago

benmarch commented 9 years ago

At a glance, this doesn't look like it will work properly... the promise returned by lookupTemplate() is resolved with the compiled template, not a http response object: https://github.com/selvach/angular-bootstrap-tour/blob/d5fbcfb9192745fed240481127ae51672e2249e7/app/tour_helpers.js#L53-L60

However, I haven't tested this locally so maybe I am missing something?

benmarch commented 9 years ago

I received another PR with the exact same change so I have merge it in (his contained the distribution code so I merged his instead.) I still haven't tested it, but thank you for pointing it out. Released version 0.3.4-rc.1