search

benmarch / angular-ui-tour

Product tour using Angular UI Bootstrap Tooltips
163 stars 49 forks source link

Disabled next and previous buttons #161

Closed jrdn91 closed 7 years ago

jrdn91 commented 7 years ago

I have added the ability to disable next and previous buttons in steps, as well as hiding the next and previous buttons.

I also added an option to the pause button to hide it as well if there is a desire to force the user to not be allowed to pause.

I was not able to write tests for this feature as I'm not very well versed in writing tests and don't really know how to get a test that can work for this feature.

Currently, the ng-disabled and ng-hide attributes are bound to the property passed in. I'm guessing that this is because it doesn't have access to the scope that the property is trying to be bound to, so that would need some way of getting access to that I suppose.

I realize this is a really bad PR but I figure if anything it's a good start for a decent feature to your plugin.

benmarch commented 7 years ago

Hi @Jordan4jc, sorry for the delayed response. Unfortunately, I'm not going to merge this because it adds complexity to the configuration, and you can achieve this functionality in your app by overriding the templateUrl property of the step.

Regarding your issue #160, I'll look into adding that feature in the next major release.