search

benmarch / angular-ui-tour

Product tour using Angular UI Bootstrap Tooltips
163 stars 49 forks source link

Resolution of positioning problem #185

Open k-soze opened 6 years ago

k-soze commented 6 years ago

The positioning did not work when positionPopup(step) was called after setting the visibility and display style because the width and height (used in tether) of the popup were equal to 0.

benmarch commented 6 years ago

Hey @k-soze I'm sorry I never saw this come in. Thank you for the PR, I'll take a look. In the meantime I am releasing an update that should fix most of the positioning issues.

ross-byrne commented 5 years ago

+1 for this PR. @benmarch this seems to have fixed some placement issues I was experiencing. Some of the pop ups were appearing shifted a few inches to the right when the options 'bottom' or 'left' where being used. Until this is merged in, I'll use a forked version that includes this fix. Thanks @k-soze!