search

benmarch / spel2js

Parse Spring Expression Language in JavaScript
Other
69 stars 19 forks source link

Request to push new version to npm #4

Closed chadlwilson closed 6 years ago

chadlwilson commented 6 years ago

Hi - very useful library, thanks!

If you are ready to do so - are you able to push a new version (0.2.4 I guess) to NPM? There seems to be some packaging issue we have with the published 0.2.3 version that appears to be resolved on HEAD; possibly due to the switch to webpack; but that doesn't seem to be released yet.

benmarch commented 6 years ago

Hey @chadlwilson, thanks for the reminder, I will do that today!

chadlwilson commented 6 years ago

Great, looking forward to it!

benmarch commented 6 years ago

All set, 0.2.4 is available on NPM.

chadlwilson commented 6 years ago

Thanks, working out of the box for us on RN with Jest + RN's Metro bundler now :)

Edit: Actually, spoke too soon. react-native's toolchain doesn't seem to like the .babelrc that's sitting there in the distribution when bundling an RN app. (per https://github.com/facebook/react-native/issues/4062) Not sure how you'd feel about excluding this from the NPM package though...

chadlwilson commented 6 years ago

Should the bower.json also be updated btw? Doesn't affect our usage, but thought I'd ask.

benmarch commented 6 years ago

Thanks for pointing that out! I just released 0.2.5 without .babelrc and fixed the release config to include bower.json.