search

benmarten / CryptoETF

Portfolio Overview Tool for Your CryptoCoin Capitalization-Weighted Portfolio.
Apache License 2.0
396 stars 77 forks source link

Enable minValueBtc in displaying portfolio output #26

Closed doitlikepruett closed 6 years ago

doitlikepruett commented 6 years ago

This closes #24.

benmarten commented 6 years ago

I actually realized after merging, that it's not working like this. If we don't allow adding coins to the portfolio with a 0 value, then this defeats the original purpose of showing you the coins that you don't have but that are recommended based on their marketcap. I think what you are trying to achieve can be done with the already existing settings: https://github.com/benmarten/CryptoETF#settings

- minValueBtc: Ignore coins that only have a holdingsvalue under a certain bitcoin value.
- hideMissingCoins: By default CryptoETF will add all missing coins up to your last coin holding by rank of the coin (global market cap). This option disables that behaviour.
doitlikepruett commented 6 years ago

Thanks Ben. I guess I didn't understand the documentation for these two options. minValueBtc and hideMissingCoins control hiding and showing the recommended positions above minValueBtc right? Not hiding or show coins you don't own that have amount === 0.

benmarten commented 6 years ago

Sry, just saw your reply. Yes that's correct. I hope the second option helps in your case...