search

benmarten / CryptoETF

Portfolio Overview Tool for Your CryptoCoin Capitalization-Weighted Portfolio.
Apache License 2.0
396 stars 77 forks source link

Does it make sense that Total doesn't include any amounts currently in a pending trade? #37

Open kalepail opened 6 years ago

kalepail commented 6 years ago

I would like and expect to see the total amount for any coin to include any amounts in pending trades. Seems to be a little inconsistent too as GDAX seems to do this but Binance does not. Curious if this is an API limitation or expected behavior or what.

benmarten commented 6 years ago

That is expected behavior at this point, as most exchanges will return you something like this as response:

{
  "holdings": [],
  "holdingsOnTrades": []
}

I guess this would require looking at the respective response again and adding these coins too... Feel free to set a breakpoint in the binance integration and inspect the response body... Keeping this open for now, as its prob. a good enhancement ;)