search

benmarten / CryptoETF

Portfolio Overview Tool for Your CryptoCoin Capitalization-Weighted Portfolio.
Apache License 2.0
396 stars 77 forks source link

Support for fiat currencies #39

Open gosuto-inzasheru opened 6 years ago

gosuto-inzasheru commented 6 years ago

On some of the exchanges supported we are also able to hold fiat currencies. I think it would be a nice addition to see these fiat currencies in the portfolio too. They wouldn't participate in the market allocation obviously but as an alternative to targetValueUsd we could set a targetValuePerc relative to the total portfolio's value.

benmarten commented 6 years ago

hm, but would you hold all your fiat currencies in the exchanges? Holding in the exchanges in the first place is already a bit risky....

The targetValueUsd was initially design to cover this use case: Let's assume you're total portfolio, including stocks, bonds, crypto is 100k. Now you decide to keep crypto at 10% of your portfolio, that's where you would add 10000 as targetValueUsd.

barryvdh commented 6 years ago

You could enter the rest of the fiat manually perhaps. But I guess it sometimes makes sense to keep some fiat on your exchange even though it's risky, but if you want to buy cheap in a dip, you need fiat available quickly.

gosuto-inzasheru commented 6 years ago

It depends on what kind of terms you are trading maybe. If your goal is a long term portfolio of maybe five years and you rebalance maybe every quarter, then I guess all that fiat is at risk on exchanges.

On a shorter term however I could see rebalancing happening maybe every week. Depending on whether the market is bearish or bullish, it would then also be nice to be able adjust crypto/fiat balance. Like @barryvdh mentions, basically buying the dips and selling the peaks.

I do share your worry about keeping all this fiat in exchanges but that's everybody's personal choice right? If the fiat is there and we can read it, might as well report it in the portfolio.

benmarten commented 6 years ago

Right, didn't want to get hung up on the fiat holding strategy ;)

So do you essentially want to include FIAT just like the regular coins?

I think we'd have to do some different handling for fiat... maybe also a new class ;)