search

benmarten / CryptoETF

Portfolio Overview Tool for Your CryptoCoin Capitalization-Weighted Portfolio.
Apache License 2.0
396 stars 77 forks source link

Manual allocation #41

Closed gosuto-inzasheru closed 6 years ago

gosuto-inzasheru commented 6 years ago

Quick solution to #40. Note that this does not allow you to set percentages directly, merely give each coin 'points' which are calculated to percentages based on the total points given to all coins that are held.

benmarten commented 6 years ago

Hi, thanks for this commit. Makes a lot of sense.... I'm still a bit hesitant to merge this. I feel we should at least support percentages, otherwise it could be a bit confusing... We should also add at least an entry in the readme and in the settings.example.json.

I think we can potentially address this with the Strategy class that I mentioned earlier... ;)

gosuto-inzasheru commented 6 years ago

In a way percentages is supported. If you fill in 66.66 and 33.33 it will do the trick (actually rebalance to 66.67 and 33.33). It's just that with this factor calculating it is just as easy to fill in 2 and 1 or 6 and 3. No errors can be made either, allocation will never go above 100% for example. Whatever is filled in manually, the allocation sum will always be 100%. I think this is therefore a more fool proof way of handeling manual data...

I will check out the conflict in README.md.

gosuto-inzasheru commented 6 years ago

Should be good now, following ca7929f.

benmarten commented 6 years ago

Looks good now. Thx