search

benmarten / CryptoETF

Portfolio Overview Tool for Your CryptoCoin Capitalization-Weighted Portfolio.
Apache License 2.0
396 stars 77 forks source link

Formatting more precise #47

Open gosuto-inzasheru opened 6 years ago

gosuto-inzasheru commented 6 years ago

Needed more precision as some coins might just be a fraction of the total portfolio, but still need proper display. Don't know if everybody agrees... A more elegant solution would be to let users define the amount of decimals for fiat and crypto in the settings maybe. Implementation for this is tougher though due to testFormat.js ;-)

benmarten commented 6 years ago

Thx for your PR. Yeah I agree that we definitely should add this into the settings. Right now it would be a breaking change, that not all users could agree with... Wouldn't this kinda negate your earlier PR: https://github.com/benmarten/CryptoETF/pull/50 ?