benmarten / CryptoETF

Portfolio Overview Tool for Your CryptoCoin Capitalization-Weighted Portfolio.
Apache License 2.0
396 stars 77 forks source link

npm package-lock.json #49

Closed gosuto-inzasheru closed 6 years ago

gosuto-inzasheru commented 6 years ago

Apparently these need to be committed when updated. Other options are to add it to.gitignore and/or add a .npmrc file to each repo with package-lock=false as its contents, which prevents the file from being created by npm install.

gosuto-inzasheru commented 6 years ago

Also I get these warnings when running npm install:

npm WARN babel-loader@6.4.1 requires a peer of webpack@1 || 2 || ^2.1.0-beta || ^2.2.0-rc but none is installed. You must install peer dependencies yourself.
npm WARN @1.8.1 No repository field.
npm WARN @1.8.1 No license field.
benmarten commented 6 years ago

Removed package-lock.json here: https://github.com/benmarten/CryptoETF/commit/5ee0c6c7510b784b148cb42644974eeb238750df