search

benmarten / CryptoETF

Portfolio Overview Tool for Your CryptoCoin Capitalization-Weighted Portfolio.
Apache License 2.0
396 stars 77 forks source link

Add Kraken integration #7

Closed barryvdh closed 6 years ago

barryvdh commented 6 years ago

Pretty similar to Bittrex, only difference is that crypto coins are denoted with an 'X', and fiat with 'Z', so XXBT, XXRP, XLTC, XETH etc, but not for BCH. Euro is ZEUR. I've stripped the first X from the currency. But bitcoin also needs to be converted from XBT to BTC, I've just added that to the settings, or should I hardcode it?

seffignoz commented 6 years ago

I hate Kraken... worst API ever, inconsistent naming across currencies. Also you might have bitcoin as "XBT" and "XXBT" for no reason...

barryvdh commented 6 years ago

Yeah it's not great, and it's pretty slow recently (that's why I've bumped it to 10 sec timeout instead of 5).

But that's why I added the mapping there.

benmarten commented 6 years ago

Looks good to me ;) I personally don't use Kraken, but whatever works for you ;) I thinks stripping is a feasible solution... Thanks for contributing :)