benmarwick / JSTORr

Simple text mining of journal articles from JSTOR's Data for Research service
Other
71 stars 18 forks source link

JSTOR's new .zip format for DfR results breaks package syntax #34

Open felixhaass opened 6 years ago

felixhaass commented 6 years ago

Hi there,

first of all, let me thank you for the JSTORr package which sounds like an extremely useful piece of software. Thanks for the work in putting this together!

When trying the package this morning, however, the basic command fails (where the working directory is the unzipped received .zip file):

unpack1grams <- JSTOR_unpack1grams()

It seems like JSTOR has changed the contents of the .zip file it generates, since no citations.tsv file is generated, either, but a bunch of xml files instead. Here's a sample .zip file to reproduce the error.

Best, Felix

benmarwick commented 6 years ago

Thanks for letting me know, this happens from time to time, they change their output format with no warning or news. I will take a look!

BillyHall5 commented 6 years ago

Ben, Like felixhaass I'm super excited by your JSTORr package. It is perfect for what I need to do with journal data. But like him I'm also having difficulty now that JSTOR has changed the format of the files it delivers. I tried to mimic the files by converting the xml metadata to citatiouns tsv and the ngram1 txt files to wordcount csv files. But no luck same error with the basic command:

unpack1grams <- JSTOR_unpack1grams("path = . . .)

The error i get is:

Error in setwd(paste0(path, "/wordcounts")) : cannot change working directory

Can you suggest any work arounds? I'm very much a beginner with programming, but I've got lots of help when the will gives out. Thanks again for this really powerful tool.

All the best, Billy

benmarwick commented 6 years ago

Thanks for the reminder about this issue, I'll take a look.

In the meantime, you may find this pkg useful: https://github.com/tklebel/jstor

BillyHall5 commented 6 years ago

Thanks for the suggestion and thanks again for developing such great tools. —Billy

On Mar 10, 2018, at 6:43 PM, Ben Marwick notifications@github.com wrote:

Thanks for the reminder about this issue, I'll take a look.

In the meantime, you may find this pkg useful: https://github.com/tklebel/jstor https://github.com/tklebel/jstor — You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/benmarwick/JSTORr/issues/34#issuecomment-372082251, or mute the thread https://github.com/notifications/unsubscribe-auth/Ajhz_QaoNJYn6IKzDKm6Uh70p0LBQtJ2ks5tdIFWgaJpZM4Qz0pl.

brycehansche commented 6 years ago

Ben, Thank you for making this tool, and for the suggestion for the additional tool! I was just wondering if there was any update on this current issue. -Bryce