benmarwick / JSTORr

Simple text mining of journal articles from JSTOR's Data for Research service
Other
71 stars 18 forks source link

findassocs #7

Closed josswhittaker closed 11 years ago

josswhittaker commented 11 years ago

findassocs <- JSTOR_findassocs(unpack, corpus, n = 10, "neolithic", topn = 20) Error in which(x.cor[1, ] > corlimit & x.cor[2, ] < plimit) : subscript out of bounds

What's going on here? Did "neolithic" get removed because it was assumed to be an adjective?

benmarwick commented 11 years ago

And what happens when you try it with the default parameters or with other parameters, the same? Try altering the plimit and let me know what happens

josswhittaker commented 11 years ago

Changing parameters doesn't seem to help. Something about that word upsets that function. Works fine with other functions, though. On May 21, 2013 9:03 PM, "Ben Marwick" notifications@github.com wrote:

And what happens when you try it with the default parameters or with other parameters, the same? Try altering the plimit and let me know what happens

— Reply to this email directly or view it on GitHubhttps://github.com/UW-ARCHY-textual-macroanalysis-lab/JSTORr/issues/7#issuecomment-18256324 .

benmarwick commented 11 years ago

Running this after adding the word to the tagdict as a NN:

findassocs <- JSTOR_findassocs(unpack1grams, nouns, n = 10, "neolithic", topn = 20)

with the revised function works fine with no errors. Thanks for bringing this up, editing the tagdict was a key detail that I hadn't considered.