Upper Case in github repo leads to error in docker build

[MartinHinz]

from Travis run:

$ docker build -t $REPO .
invalid argument "MartinHinz/mytestpackagerr" for t: invalid reference format: repository name must be lowercase

Question: generally catch this by lowercase for docker?

[MartinHinz]

Just tried it out, the place seem to be actually the first initialisation of REPO in

env:
  global:
  - REPO=martinhinz/mytestpackagerr

tried it somewere lower by hand in after_success, but there it had no effect

[benmarwick]

hmm, I can't immediately think of what is going on there!

[benmarwick]

Are your GitHub and hub.docker.com usernames exactly the same? This is assumed by the function.

[MartinHinz]

Actually not, because docker, but not Github, forced me loser case. Should have been wiser choosing my Github name in the first place.

[MartinHinz]

So, for all the people that were as inconsistent as me, is it worth adding a param for entering a divergent username for dockerhub?

[benmarwick]

Does it work if you use your hub.docker.com username in this?

env:
  global:
  - REPO=martinhinz/mytestpackagerr

[MartinHinz]

Yes, id did. But it is not very obvious to someone not having got your lesson to know that this line in the travis.yml is the one that alters the behaviour in respect to docker. But maybe renaming REPO to DOCKERREPO might do that trick, or do I miss something of its relevance?

[benmarwick]

I see, thanks. So maybe we can have an argument for the docker hub username like this:

rrtools::use_dockerfile(hub_username = github_username)

The default would be the user's GitHub username. But then you have the option to easily supply a different one for the Dockerfile. For people who enjoy complicated online lives with many different usernames :stuck_out_tongue_winking_eye:

[MartinHinz]

The man with a thousand faces

[MartinHinz]

Shall I implement that for you?

[benmarwick]

Sure, thanks!