benmarwick / rrtools

rrtools: Tools for Writing Reproducible Research in R

Other

672 stars 85 forks source link

Package with dot in name not captured by rrtools::add_dependencies_to_description() #146

Closed see24 closed 2 years ago

see24 commented 2 years ago

I am using the package spatstats.geom and it was missed by rrtools::add_dependencies_to_description() I think because of the "." in the package name. Could that be fixed in the regex here? (Sorry I don't have the regex skills to confidently suggest how)

https://github.com/benmarwick/rrtools/blob/3f830bce55e733f17e599a632a4e930ee82b8edb/R/core_manage_dependencies.R#L136

nevrome commented 2 years ago

145 should address that - could you check the PR @benmarwick?

benmarwick commented 2 years ago

Thanks so much for spotting this @see24 and @nevrome for the quick fix! I have checked the PR and tested it locally and it addresses the issue, thank you again. @see24 do let us know if you have any further issues.