benmarwick / rrtools

rrtools: Tools for Writing Reproducible Research in R
Other
671 stars 85 forks source link

mixed case GH repo name makes Travis build fail #40

Closed mrecos closed 6 years ago

mrecos commented 7 years ago

Uppercase characters in the global - REPO=$DOCKER_SER/REPO from line 5 of .travis.yml cause the build to fail with error:

invalid argument "mrecos/DistRegLMERR" for t: Error parsing reference: "mrecos/DistRegLMERR" is not a valid repository/tag: repository name must be lowercase

https://travis-ci.org/mrecos/DistRegLMERR/builds/274845050#L498

Manually changing it to lowercase allowed the build to proceed with no errors. I believe the repo name is originated here: https://github.com/benmarwick/rrtools/blob/3f2d5cff09564860692e79740b03b8f0a2912df4/R/git.R#L133 adding a tolower() in there somewhere could resolve the issue. Additionally, I tested to see if a lowercase repo name had any negative effect on the build where it is also used in line 25 of travis.yml. The travis build passed in both cases.