search

benmarwick / rrtools

rrtools: Tools for Writing Reproducible Research in R
Other
671 stars 85 forks source link

See discussion in #43 #52

Closed nevrome closed 6 years ago

nevrome commented 6 years ago

The use_analysis() problem in the test environment seems to be caused by an insufficient path definition. Please check. I don't want to add a solution that solves the problem for the test environment but renders the function useless for the actual use case :-)

43

nevrome commented 6 years ago

I accidentally mixed the small path fix and the travis experiments into one PR. Sorry.

Concerning the travis thing: The R package check works now. The docker build fails, because the $DOCKER_USER variable is not set (on travis?). I guess that's not intended behavior?

nevrome commented 6 years ago

Just to hopelessly overload this PR I now also started to add tests and minor fixes necessary for them.

nevrome commented 6 years ago

Thanks for merging, Ben.

The docker build fails because of two problems. The first one concerning missing environment variables should solve itself with your next commit if I understand this correctly? (https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions) The second one seems to be an installation problem with usethis. The commit history shows that you already managed to solve this in the past.

benmarwick commented 6 years ago

Thanks for the heads-up on the usethis problem, looks like the version of R in our docker container was getting a bit old, and missing some dependencies for usethis. I've bumped the version number for R in the docker file, and it looks like that's solved the build problem: https://circleci.com/gh/benmarwick/rrtools/61