search

benmarwick / rrtools

rrtools: Tools for Writing Reproducible Research in R
Other
670 stars 85 forks source link

hadley/requirements #65

Closed nevrome closed 5 years ago

nevrome commented 6 years ago

@dakni and I wrote the add_dependencies_to_description() function to search the code in the repository for package dependencies. I've just seen that @hadley started to work on a package to do exactly this. I expect it to be or at least to become more sophisticated than our function.

This issue is supposed to be a reminder that we could replace and improve our function in the future relying on hadley/requirements.

benmarwick commented 6 years ago

Yes, I saw that. I like your function because it works really well, and means we don't need additional dependencies. Well, let's see how Hadley's pkg develops and if it gets any amazing features that make it irresistible.

hadley commented 6 years ago

FWIW requirements is being pulled out of packrat so we can have one canonical system for determining package dependencies. The goal is to keep requirements low-dependency so it can be easily used by other packages.

nevrome commented 6 years ago

@hadley That sounds good! Do you have a timetable for this project? I guess you will provide a CRAN release?

@benmarwick IMHO we could do with some more, carefully selected dependencies. rrtools is a very high level package anyway.