Closed nevrome closed 5 years ago
Yes, thanks for raising this, and summarizing the options so nicely. Should we take a vote about what do to?
Haha - now I'm really curious about the result of a survey.
I personally suggest to copy/reimplement the code. I believe all of these five functions are very small and simple helpers. And as far as I remember rrtools already contains initially foreign code.
A potential headache with copying the functions is that usethis is GPL licensed. Google says that reusing GPL code under an MIT license isn't kosher. I think you'd have to dual-license the entire package as MIT and GPL (keeping the two parts separate), or switch to GPL.
Fortunately, since this was opened, usethis has decided to export its UI functions, including done()
, todo()
, field()
and value()
. See r-lib/usethis/issues/308. So we could just switch to using the exported version on usethis's next release.
That just leaves usethis:::git_uncommitted()
to deal with.
Thanks, we're now using the newly exported functions from usethis, and we have a local custom version of git_uncommitted()
We get a new NOTE in the check results:
We have four options to deal with this: