Not sure if this is helpful, but I'm keen to practice git and have been looking for an opportunity for my first pr. Learnt stuff from this experience, so time not wasted :smile:.
So, from a cursory look into this, it's not an error, but something that will be fixed when you submit to CRAN.
However, as that discussion notes, github releases are becoming more and more adopted. I find myself needing to cite packages before they hit CRAN. Seems like there's increasing need to have citation() be fully functional for github release.
I've tried adding a Date field (with the date of your last commit) to the DESCRIPTION. When I tried installing it with that it no didn't throw the error on my machine.
benmarwick
commented
5 years ago
Hi Ben,
Not sure if this is helpful, but I'm keen to practice git and have been looking for an opportunity for my first pr. Learnt stuff from this experience, so time not wasted :smile:.
So, from a cursory look into this, it's not an error, but something that will be fixed when you submit to CRAN.
However, as that discussion notes, github releases are becoming more and more adopted. I find myself needing to cite packages before they hit CRAN. Seems like there's increasing need to have
citation()be fully functional for github release.I've tried adding a Date field (with the date of your last commit) to the DESCRIPTION. When I tried installing it with that it no didn't throw the error on my machine.
Cheers, Charles :notes: