benmarwick / rrtools

rrtools: Tools for Writing Reproducible Research in R
Other
670 stars 85 forks source link

Allow symlinks in `use_compendium()` #80

Closed antass closed 5 years ago

antass commented 5 years ago

When initiating a new compendium with:

rrtools::use_compendium("~/path/to/new/compendium")

where ~/path/to/new is a symlink to /some/other/path, rrtools throws an error:

> rrtools::use_compendium("~/path/to/new/compendium")
Error: '/home/nfs/user.name/path/to/new' is not a directory.

However, replacing symlink with full path works:

rrtools::use_compendium("/some/other/path/compendium")
nevrome commented 5 years ago

Thanks for pointing this out, @antass.

rrtools::use_compendium is only a wrapper function for usethis::create_package to add some checks, messages and interactivity. The error you're reporting stems from usethis::create_package. I suggest you report it here to inform the usethis developers. If they fix the issue, then it will work in rrtools as well.

nevrome commented 5 years ago

@antass Did you open an issue in the usethis repository?

antass commented 5 years ago

@nevrome Just did. Thanks for the reminder. Feel free to close this.

nevrome commented 5 years ago

Ah - great. https://github.com/r-lib/usethis/issues/794

We can reopen the issue if, contrary to expectations, they should send you back.