search

benmatselby / atom-php-checkstyle

✅ [DEPRECATED] Checkstyle reporter for PHP, utilising phpcs, phpmd, php linter and php-cs-fixer
MIT License
21 stars 5 forks source link

As a user, I want the sniffer to execute on save #2

Closed benmatselby closed 10 years ago

benmatselby commented 10 years ago

When a user saves the current file, I want the sniffer to execute for me.

Need a configuration option for this

mbrevda commented 10 years ago

+1, save and maybe on open, too

mbrevda commented 10 years ago
  1. Uncaught TypeError: Object # has no method 'destroy' php-checkstyle.coffee:23file:///Users/mbrevda/.atom/packages/php-checkstyle/lib/php-checkstyle.coffee

on update?

On Wed, Mar 5, 2014 at 10:42 AM, Ben Selby notifications@github.com wrote:

Closed #2 https://github.com/benmatselby/atom-php-checkstyle/issues/2via 17433cfhttps://github.com/benmatselby/atom-php-checkstyle/commit/17433cfef8b320439c0eeb9126b1b3d23ab8de41 .

— Reply to this email directly or view it on GitHubhttps://github.com/benmatselby/atom-php-checkstyle/issues/2 .

benmatselby commented 10 years ago

Package update?

mbrevda commented 10 years ago

yeah, getting that error when I click Install Now

On Wed, Mar 5, 2014 at 11:01 AM, Ben Selby notifications@github.com wrote:

Package update?

— Reply to this email directly or view it on GitHubhttps://github.com/benmatselby/atom-php-checkstyle/issues/2#issuecomment-36721938 .

benmatselby commented 10 years ago

Can you deactivate it, close atom, and re-add. Were you on 0.7.0 before going to 0.8.0? Oddly the main code is the same as GH packages, so unsure why this is impacting this package atm

mbrevda commented 10 years ago

Deactivate [error], close Atom, reopen, Install (still deactivated), Active, seems ok (although most of the settings are gone until I close Settings and reopen)