search

benmatselby / atom-php-checkstyle

✅ [DEPRECATED] Checkstyle reporter for PHP, utilising phpcs, phpmd, php linter and php-cs-fixer
MIT License
21 stars 5 forks source link

As a user, I would like to see different colours to highlight warnings & errors. #20

Closed Stubbs closed 10 years ago

Stubbs commented 10 years ago

At the moment everything is highlighted in red which makes it hard to spot other errors like syntax errors.

benmatselby commented 10 years ago

Yeah, this is a good feature request, but can only really do it with phpcs as phpmd does not differentiate between errors.

So two options:

Linter errors are Red All other items are Orange (phpcs, phpmd etc)

or

Each tool has a colour, so Linter is Red, phpcs is blue, phpmd is purple etc.

Thoughts?

Stubbs commented 10 years ago

You could do both with a bunch of config options ...

Mind if I have a crack at this? I'll send you a PR?

benmatselby commented 10 years ago

Nah, go for it.

My thoughts would be to actually just add classes to the div. so phpcs phpmd phplinter error warning etc. prefix with php-checkstyle so no conflicts and then document in Readme how you set your own style sheet.

This way, no more config options which can start to become a tad cumbersome to please everyone. Gives freedom to developers to pick their own colours by type or tool.