search

benmatselby / atom-php-checkstyle

✅ [DEPRECATED] Checkstyle reporter for PHP, utilising phpcs, phpmd, php linter and php-cs-fixer
MIT License
21 stars 5 forks source link

Uncaught TypeError: Cannot read property 'length' of undefined #22

Closed yriveiro closed 10 years ago

yriveiro commented 10 years ago

I'm running in this bug when I click the listview.

screenshot 2014-04-04 00 20 28

screenshot 2014-04-04 00 20 46

The command on dev-tools window is:

[php-checkstyle]/usr/local/bin/php -l -d display_errors=On /Users/yriveiro/Development/test.php; /usr/local/bin/phpcs --standard=PSR2 --report=checkstyle /Users/yriveiro/Development/test.php; /usr/bin/phpmd /Users/yriveiro/DevelopmentUsers/yriveiro/Development/test.php text codesize,cleancode,controversial,naming,unusedcode;  commands.coffee:20

I think that the first error is not on any row of the file and It's like a advice or something. When I click in the listview is not possible goto the row X and throws the error.

benmatselby commented 10 years ago

Aye, looks like the regex is being too greedy due to the brackets in the output.

benmatselby commented 10 years ago

Updated the regex and published 0.15.0