benmatselby / sublime-phpcs

🔍 PHP CodeSniffer, PHP Coding Standard Fixer, Linter, and Mess Detector Support for Sublime Text
Other
812 stars 126 forks source link

Fixes the execution of Php-cs-fixer #115

Closed rafaelndev closed 10 years ago

rafaelndev commented 10 years ago

This pull request fixes the issue #113, also occurring in sublime text 2.

screenshot - 10-07-2014 - 11 07 55

benmatselby commented 10 years ago

What OS does this fix for Mac or Linux? As it is working on the Mac OS by setting:

"php_cs_fixer_show_quick_panel": true
rafaelndev commented 10 years ago

On Linux. I already have this setting set to true. But the problem isn't just the panel, without the fix, the php-cs-fixer don't execute, only show the args in the console, but without return (output).

I only tested this on linux, as i don't have another OS. Specifically on Xubuntu 14.04 x64, Kernel 3.13, os python version 2.7.6, running Sublime Text 2.0.2.

benmatselby commented 10 years ago

Seems to be a linux only issue, but working on Mac OS X. I no longer have a windows machine, so unless I get tickets raised against windows, the patch is merged. Thanks for resolving.