benmiroglio / pymatch

MIT License
276 stars 129 forks source link

drop_static_cols actually drops a column and breaks fit_scores() #40

Open ntellakula opened 4 years ago

ntellakula commented 4 years ago

Within Matcher.fit_scores(), if uf.drop_static_cols() actually drops a column, then the following line patsy.dmatrics breaks. As it uses the entire formula, since df no longer has the dropped static column, the formula argument has one extra X variable.