benmiroglio / pymatch

MIT License
276 stars 129 forks source link

Exclusion Features - Shouldn't they be allowed to be NULL? #42

Open Jentwisle opened 4 years ago

Jentwisle commented 4 years ago

Shouldn't the exclusion column handling happen before removing rows with Nan?

I couldn't figure out why my sample size was being reduced so much until I stepped through the code and realized that it doesn't care about the exclusion feature list prior to dropping rows.

I generally perform isna checks on my matching features prior to creating the matcher object.

Thoughts?