benmiroglio / pymatch

MIT License
276 stars 129 forks source link

About threshold parameter of match function #8

Open taka1234 opened 6 years ago

taka1234 commented 6 years ago

Thank you for the develpoment of the great module. I'm not sure you intend as the specification or not, the threshold parameter of match function is not used when 'min' is set as the value for the method parameter (the 188th line of the code below ). https://github.com/benmiroglio/pymatch/blob/master/pymatch/Matcher.py If 'random' is set for the method parameter, the threshold parameter works. I hope this comment would be useful for the improvement of the great module.