search

benmurphyy / pe

0 stars 0 forks source link

No check on validity of file data if edited manually #2

Open benmurphyy opened 2 years ago

benmurphyy commented 2 years ago

As mentioned in the User Guide,

Screenshot 2022-04-16 at 2.22.10 PM.png

However, advanced users may edit the JSON file manually, as stated in the user guide. Thus it is not reasonable to not run any validation checks on the integrity of the data manually entered into the JSON file, such as duplicate meeting times. As that is something that could occur given modification by a user, even an advanced one, by accident. Not detecting this means that their experience with the HustleBook could differ from what it is supposed to be, and they may only find out later when they encounter issues due to duplicate data.

nus-se-bot commented 2 years ago

Team's Response

Hi! Thank you for bringing up this issue. As stated in the UG, manually editing the file would mean that the user knows what they are doing as they chose to do it manually rather than using the commands in the application. Furthermore, we already cautioned that incorrect data can also wipe all their data, hence, we believe that sufficient warning is provided to ensure that the user is responsible for any issues that occur from manually editing the data file.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]