nus-pe-bot
commented
2 years ago Team's Response
Hi! Thank you for bringing up this issue. This is to allow greater flexibility to users as clients can share the same phone number. For example, a family can have the same house number.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: Granted, it is possible that 2 clients in a rare situation may have the same phone number (like a house number). However, the issue is not that HustleBook ultimately allows duplicate phone numbers, rather, the issue is that there is no indication to the user when they add a client with the same phone number as an existing client, that they have done so. Given how easy it is to mistype phone numbers, and how few numbers some phone numbers have, it is possible if a financial advisor has many clients, that they may mistype the phone number for a new client making it a duplicate of an exiting client's phone number. This could cause confusion and inconvenience for the financial advisor later on.
Given that most clients would probably give their personal phone number (AKA mobile phone) to a financial advisor instead of house number (for privacy reasons), the rarity of having two clients with the exact same phone number, along with the fact that implementing a simple check against existing phone numbers for each add command would not have involved significant work over the work done by v1.4, I think that omitting it constitutes a feature flaw.
Thus due to the above explanation and the possibility of causing inconvenience to some users in a rare scenarios (like incorrectly typed phone numbers), i classify this as a Low grade Feature flaw.
As stated, there is no check performed warning or prevention when i try to add a user with a phone number that another user already has in HustleBook. This is a problem as I could have entered that phone number by accident, and now there are two clients with same phone number in HustleBook which is highly likely not correct, given in reality people have unique phone numbers (almost all the time).