nus-pe-script
commented
2 years ago Team's Response
Hi! Thank you for bringing up this issue. We took into consideration that some clients working in large companies would be using a centralized email for their communication, hence, we allowed for the same emails between clients.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: Consider the target user and application of HustleBook - Financial Advisors managing their clients. It is very unlikely that two clients of a financial advisor would have the exact same email, as all, if not most emails of their clients would be unique personal emails. (meaning only 1 person can access that email) Usually centralised emails for companies are for general services like customer queries. Hence such emails are very unlikely to appear. If multiple clients shared the same email, then information regarding the financial advisors dealings with each client would be visible to both clients, violating privacy and potentially causing confusion.
Also it is not mentioned in the User Guide that duplicate emails are accepted. I think many users would expect that duplicate emails would not be accepted due to the above mentioned argument.
Regardless, even if one were to consider the remote possibility that the same email could be shared by two clients, the application should inform the user if they have entered in a duplicate email before they can proceed with the command. Because it is more probable, given how unlikely duplicate emails are among clients, that they typed in the duplicate email by accident (typo) rather than really having that email. Hence the appropriate thing to do would be inform the user of this duplication, then only allow it on confirmation by the user.
Also, implementing a simple check on existing emails when adding a new client would not have involved significant work, compared to the work that was already done by v1.4, like the undo command.
Thus due to the importance the feature of duplicate email detection being missing in HustleBook, this is a feature flaw of Low severity, as in certain rare scenarios, some users may end up having clients with duplicate emails when in reality that is not the case, causing inconvenience.
As stated, there is no check performed warning or prevention when i attempt to add a user with an email that another user already has in HustleBook. This is a problem as I could have entered that email by accident, and now there are two clients with same email in HustleBook which is highly likely not correct, given in reality people have unique emails. (almost all the time).