search

benmurphyy / pe

0 stars 0 forks source link

Unable to add or edit a person with tags that have spaces in them #6

Open benmurphyy opened 2 years ago

benmurphyy commented 2 years ago

As stated, I cannot add or edit a person who has a tag with spaces in them, e.g. "good client". The command will simply be rejected. This is likely will cause inconvenience for some clients as no where in the user guide is it stated that tags cannot have spaces, only that they are limited to 25 characters. Screenshot 2022-04-16 at 2.42.24 PM.png Screenshot 2022-04-16 at 2.43.32 PM.png

soc-pe-bot commented 2 years ago

Team's Response

Hi! Thank you for bringing up this issue. However, spaces are not considered alphanumeric and as stated in the error message, tags can only have alphanumeric and hence, do not allow space.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The user guide only states that a tag can only have 25 characters, not that it is limited to only alphanumerics and cannot have spaces. I checked the whole user guide for any mention of it with a search for the keyword 'tag', but found no place where it states a tag cannot have spaces.
Screenshot 2022-04-20 at 4.10.33 PM.png

Referring to the CS2103 website, under functionality bug, a mismatch between UG and actual behaviour is considered either a functionality bug or documentation bug Screenshot 2022-04-20 at 4.11.02 PM.png

Thus from reading the UG, a user may have the impression that they can add tags with spaces in them (examples include "friendly client", "nice person" or "very apprehensive"), yet the actual usage of HustleBook differs from this expectation by the client. This constitutes either a Low grade functionality bug or documentation bug, as in rare cases when a user tries to add a tag with spaces, but finds himself unable to do so, he will be inconvenienced.