search

bennet0496 / nextcloud_attachments

Upload large attachments to Nextcloud and automatically create share link
MIT License
4 stars 2 forks source link

Remove HTML tags from "connected as" message. #3

Closed pabzm closed 2 months ago

pabzm commented 2 months ago

They were shown as tags on the page because they were encoded before being shown (as it's correct string handling).

Showing color is a nice idea but would need to be implemented differently, I'd say.

bennet0496 commented 2 months ago

It worked during development with version 1.6.2. I suspect something has changed since than. I will have a look with the newer version later this week. But removing the color outright is not a good option imo.

pabzm commented 2 months ago

It's the only label-string that contains an HTML-tag, thus I figured it might be the simple option. But feel free to close this if you prefer another way!

pabzm commented 2 months ago

Just a note:

It worked during development with version 1.6.2. I suspect something has changed since than.

https://github.com/bennet0496/nextcloud_attachments/blob/278f31d9ea190a3a6a1c68a2851ee893de644b71/hooks.php#L127

Here the plugin-code uses htmlentities on the string, which suits as an explanation as far as I can see.

bennet0496 commented 2 months ago

Oh I see. I changed something... Well yeah, then for now let's remove the html from the translation strings and I will look for better styling when I have a bit more time again.

bennet0496 commented 2 months ago

And thank you for your contribution btw. Greatly appreciated :)