search

bennettdams / eslintconfig.dev

Collection of curated ESLint configurations
https://eslintconfig-dev.vercel.app/
37 stars 3 forks source link

Packaged merged into prettier #16

Closed cabello closed 2 years ago

cabello commented 2 years ago

Got the following error when following the website:

Error: "prettier/@typescript-eslint" has been merged into "prettier" in eslint-config-prettier 8.0.0. See: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21

Given it has been merged upstream, I removed the recommendation.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
eslintconfig-dev ✅ Ready (Inspect) Visit Preview Jul 25, 2022 at 2:13PM (UTC)
bennettdams commented 2 years ago

I followed your changes locally and can confirm that with this change the error message disappears.

To be honest, I haven't touched this CRA setup for a long time, as I switched to Next.js completely, so I'm not sure about other problems though.

bennettdams commented 2 years ago

@all-contributors add @cabello for tools

not working ¯\(ツ)/¯

bennettdams commented 2 years ago

Oops, didn't mean to close 😅

bennettdams commented 2 years ago

@all-contributors please add @cabello for tools

allcontributors[bot] commented 2 years ago

@bennettdams

I've put up a pull request to add @cabello! :tada: