search

bennetthardwick / rust-obs-plugins

A safe wrapper around the OBS API, useful for creating OBS sources, filters and effects.
GNU General Public License v2.0
187 stars 32 forks source link

Add registering hotkeys for sources #8

Closed bennetthardwick closed 3 years ago

bennetthardwick commented 3 years ago

@chengyuhui when you get a chance can you see if this works for you? I tried it with the scroll focus filter and it didn't work.

kmod-midori commented 3 years ago

Well, maybe later today, currently working on courseworks. I think maybe we've got something wrong as this feature is used everywhere (it's poorly documented anyway).

bennetthardwick commented 3 years ago

Tested again, this time with a SourceType::INPUT instead of a SourceType::FILTER and it seems to work. I think obs just doesn't support showing hotkeys for filters.

kmod-midori commented 3 years ago

Just finished troubleshooting my PC and had some time to test, LGTM.

bennetthardwick commented 3 years ago

@chengyuhui can you take another look when you get a chance? I merged in those DataObj changes.

kmod-midori commented 3 years ago

I found that we still have problems in texture mapping (crashes OBS), gonna fix that first.