search

benningm / Mail-SpamAssassin-Plugin-RedisAWL

redis support for spamassassin AWL/TxRep
1 stars 1 forks source link

Expiry of awl_* entries? #1

Closed hildeb closed 6 years ago

hildeb commented 7 years ago

Could you add an option to automagically expire old entries? We usually use 90d...

benningm commented 7 years ago

Please test the issue-1-expire-entries branch and give feedback if does what you expect.

hildeb commented 7 years ago

After installation I'm getting:

Oct  4 11:32:57 mail-cbf amavis[45271]: (45271-03) _WARN: TxRep: Attempt to reload Mail/SpamAssassin/RedisAddrList.pm aborted.\nCompilation failed in require at (eval 1608) line 1.
Oct  4 11:32:57 mail-cbf amavis[45271]: (45271-03) _WARN: TxRep: could not open storages, quitting!
Oct  4 11:32:57 mail-cbf amavis[45271]: (45271-03) _WARN: TxRep: Attempt to reload Mail/SpamAssassin/RedisAddrList.pm aborted.\nCompilation failed in require at (eval 1609) line 1.
Oct  4 11:32:57 mail-cbf amavis[45271]: (45271-03) _WARN: TxRep: could not open storages, quitting!
Oct  4 11:32:57 mail-cbf amavis[45271]: (45271-03) _WARN: Use of uninitialized value in addition (+) at /usr/share/perl5/Mail/SpamAssassin/Plugin/TxRep.pm line 1329.
Oct  4 11:32:57 mail-cbf amavis[45271]: (45271-03) _WARN: TxRep: Attempt to reload Mail/SpamAssassin/RedisAddrList.pm aborted.\nCompilation failed in require at (eval 1610) line 1.
Oct  4 11:32:57 mail-cbf amavis[45271]: (45271-03) _WARN: TxRep: could not open storages, quitting!
Oct  4 11:32:57 mail-cbf amavis[45271]: (45271-03) _WARN: Use of uninitialized value in addition (+) at /usr/share/perl5/Mail/SpamAssassin/Plugin/TxRep.pm line 1330.
Oct  4 11:32:57 mail-cbf amavis[45271]: (45271-03) _WARN: TxRep: Attempt to reload Mail/SpamAssassin/RedisAddrList.pm aborted.\nCompilation failed in require at (eval 1611) line 1.
Oct  4 11:32:57 mail-cbf amavis[45271]: (45271-03) _WARN: TxRep: could not open storages, quitting!
Oct  4 11:32:57 mail-cbf amavis[45271]: (45271-03) _WARN: Use of uninitialized value in addition (+) at /usr/share/perl5/Mail/SpamAssassin/Plugin/TxRep.pm line 1331.
Oct  4 11:32:57 mail-cbf amavis[45271]: (45271-03) _WARN: TxRep: Attempt to reload Mail/SpamAssassin/RedisAddrList.pm aborted.\nCompilation failed in require at (eval 1612) line 1.
Oct  4 11:32:57 mail-cbf amavis[45271]: (45271-03) _WARN: TxRep: could not open storages, quitting!
Oct  4 11:32:57 mail-cbf amavis[45271]: (45271-03) _WARN: Use of uninitialized value in addition (+) at /usr/share/perl5/Mail/SpamAssassin/Plugin/TxRep.pm line 1334.
Oct  4 11:32:57 mail-cbf amavis[45271]: (45271-03) _WARN: TxRep: Attempt to reload Mail/SpamAssassin/RedisAddrList.pm aborted.\nCompilation failed in require at (eval 1613) line 1.
Oct  4 11:32:57 mail-cbf amavis[45271]: (45271-03) _WARN: TxRep: could not open storages, quitting!
hildeb commented 7 years ago 
Oct  4 11:34:55 mail-cbf amavis[49089]: (49089-01) _WARN: TxRep: Global symbol "$addr" requires explicit package name (did you forget to declare "my $addr"?) at /usr/local/share/perl/5.22.1/Mail/SpamAssas
sin/RedisAddrList.pm line 123.\nCompilation failed in require at (eval 1576) line 1.
hildeb commented 7 years ago

Maybe that line 123 should be: $self->_update_addr_expire($entry->{'addr'});

benningm commented 7 years ago

Just fixed it.

tomsommer commented 6 years ago

Could you release this to cpan?

benningm commented 6 years ago

Just pushed 1.02.