search

bennn / racket-mutt

Racket API for the Mutt email client
Other
3 stars 1 forks source link

pre-install: use find-exe-path instead of 'type mutt ....' #14

Closed bennn closed 7 years ago

bennn commented 7 years ago

@LeifAndersen can you run these 2 commands for me:

> (system "type mutt >& /dev/null")
> (find-executable-path "mutt")

I expect the 1st one to fail and the 2nd to pass. If so, I'll merge this and you should be OK.

From #13 it looks like system on your system is using sh and therefore the redirect >& isn't working. (Even if that's not the problem, my code should be using find-executable-path anyway.)

LeifAndersen commented 7 years ago

(system "type mutt >& /dev/null") /bin/sh: 1: Syntax error: Bad fd number

f

(find-executable-path "mutt")

<path:/usr/bin/mutt>

~Leif Andersen

On Thu, Aug 3, 2017 at 6:51 PM, Ben Greenman notifications@github.com wrote:

@LeifAndersen https://github.com/leifandersen can you run these 2 commands for me:

(system "type mutt >& /dev/null") (find-executable-path "mutt")

I expect the 1st one to fail and the 2nd to pass. If so, I'll merge this and you should be OK.

From #13 https://github.com/bennn/racket-mutt/issues/13 it looks like system on your system is using sh and therefore the redirect >& isn't working. (Even if that's not the problem, my code should be using find-executable-path anyway.)

You can view, comment on, or merge this pull request online at:

https://github.com/bennn/racket-mutt/pull/14 Commit Summary

  • pre-install: use find-exe-path instead of 'type mutt ....'

File Changes

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bennn/racket-mutt/pull/14, or mute the thread https://github.com/notifications/unsubscribe-auth/AARc5ntRJMNWws6mqPuRYhjyoeqbpzDBks5sUnkYgaJpZM4OtL0l .

LeifAndersen commented 7 years ago

Although when I run: $ type mutt directly in the cmdline, I get:

$ type mutt mutt is /usr/bin/mutt

~Leif Andersen

On Thu, Aug 3, 2017 at 7:20 PM, Leif Andersen leif@leifandersen.net wrote:

(system "type mutt >& /dev/null") /bin/sh: 1: Syntax error: Bad fd number

f

(find-executable-path "mutt")

<path:/usr/bin/mutt>

~Leif Andersen

On Thu, Aug 3, 2017 at 6:51 PM, Ben Greenman notifications@github.com wrote:

@LeifAndersen https://github.com/leifandersen can you run these 2 commands for me:

(system "type mutt >& /dev/null") (find-executable-path "mutt")

I expect the 1st one to fail and the 2nd to pass. If so, I'll merge this and you should be OK.

From #13 https://github.com/bennn/racket-mutt/issues/13 it looks like system on your system is using sh and therefore the redirect >& isn't working. (Even if that's not the problem, my code should be using find-executable-path anyway.)

You can view, comment on, or merge this pull request online at:

https://github.com/bennn/racket-mutt/pull/14 Commit Summary

  • pre-install: use find-exe-path instead of 'type mutt ....'

File Changes

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bennn/racket-mutt/pull/14, or mute the thread https://github.com/notifications/unsubscribe-auth/AARc5ntRJMNWws6mqPuRYhjyoeqbpzDBks5sUnkYgaJpZM4OtL0l .

bennn commented 7 years ago

very good