search

benno1237 / MinePI

Minecraft utility library
MIT License
20 stars 8 forks source link

Fixed capes issues #15

Closed Polsulpicien closed 2 years ago

Polsulpicien commented 2 years ago

Changed minecraftcapes.net url Updated set_cape method to support Optifine capes.

benno1237 commented 2 years ago

Hi, thanks for the PR. A few things I would like to change:

Now that the cape conversion logic is in set_cape, it would probably be better to call set_cape internally in the init function instead of duplicating the code.

The minecraftcapes url i used is indeed still valid. At least for me? The one you PR'd seems to accept UUIDs instead of names tho. So it would be best to dynamically use the urls based on what kind of input the function gets. Function gets a username -> use the first url Function gets a UUID -> use your url Function gets a minepi.Player object -> use the faster one