search

benno1237 / MinePI

Minecraft utility library
MIT License
20 stars 8 forks source link

Bottom arm texture missing #19

Open AlexanderMatveev opened 1 year ago

AlexanderMatveev commented 1 year ago

Source:

steve

Result:

steve

benno1237 commented 1 year ago

Hi, could you provide some more information? Like the version of the library and the code?

cspencer commented 1 year ago

This is also happening for me, and affects the bottom of both of the feet as well.

I have attached both a skin file as well as a script that demonstrates the issue. I've also attached the output generated by the script.

$ pip3 list | grep -i minepi MinePI 0.5.0

(And thank you for the MinePi module! I've had a lot of fun using it!) yoda-skin script.txt yoda-preview

benno1237 commented 1 year ago

Thanks for bringing this up again. You made me do things I swore never to do again. I rewrote the entire rendering logic. Instead of dumb coordinates, MinePI is now using a proper coordinate system with rotation matrices for each axis and body part. Thanks university for teaching me some linear algebra. Now I can actually rotate each face individually and thus also get the accurate position of each face which, coincidentally, also seems to fix your issue. Oh and did I mention it also sped the rendering process up by a few percent?

The fix is up at the develop branch. So please give it a try and let me know about any potential issues.

cspencer commented 1 year ago

@benno1237 I will check it out! Thank you for your efforts!