search

bennofs / th-lift-instances

Lift instances for common haskell data types
http://hackage.haskell.org/package/th-lift-instances
Other
12 stars 11 forks source link

More instances #13

Closed phadej closed 5 years ago

phadej commented 5 years ago

This PR primarily resolves #12.

Additionally

% cabal new-build --ghcjs -w /opt/ghcjs/8.4/bin/ghcjs
Warning: don't know how to find change monitoring files for the installed
package databases for ghcjs
Resolving dependencies...
Build profile: -w ghcjs-8.4.0.1 -O1
In order, the following will be built (use -v for more details):
 - primitive-0.6.4.0 (lib) (requires build)
 - vector-0.12.0.2 (lib) (requires build)
 - th-lift-instances-0.1.11 (lib) (first run)
Starting     primitive-0.6.4.0 (lib)
Building     primitive-0.6.4.0 (lib)
Installing   primitive-0.6.4.0 (lib)
Completed    primitive-0.6.4.0 (lib)
Starting     vector-0.12.0.2 (lib)
Building     vector-0.12.0.2 (lib)
Installing   vector-0.12.0.2 (lib)
Completed    vector-0.12.0.2 (lib)
Configuring library for th-lift-instances-0.1.11..
Preprocessing library for th-lift-instances-0.1.11..
Building library for th-lift-instances-0.1.11..
[1 of 1] Compiling Instances.TH.Lift ( src/Instances/TH/Lift.hs, /home/ogre/Documents/other-haskell/th-lift-instances/dist-newstyle/build/x86_64-linux/ghcjs-8.4.0.1/th-lift-instances-0.1.11/build/Instances/TH/Lift.js_o )

For comparison master also works for me:

% cabal new-build --ghcjs -w /opt/ghcjs/8.4/bin/ghcjs
Warning: don't know how to find change monitoring files for the installed
package databases for ghcjs
Resolving dependencies...
Build profile: -w ghcjs-8.4.0.1 -O1
In order, the following will be built (use -v for more details):
 - th-lift-0.7.11 (lib) (requires build)
 - th-lift-instances-0.1.11 (lib) (configuration changed)
Starting     th-lift-0.7.11 (lib)
Building     th-lift-0.7.11 (lib)
Installing   th-lift-0.7.11 (lib)
Completed    th-lift-0.7.11 (lib)
Configuring library for th-lift-instances-0.1.11..
Preprocessing library for th-lift-instances-0.1.11..
Building library for th-lift-instances-0.1.11..
[1 of 1] Compiling Instances.TH.Lift ( src/Instances/TH/Lift.hs, /home/ogre/Documents/other-haskell/th-lift-instances/dist-newstyle/build/x86_64-linux/ghcjs-8.4.0.1/th-lift-instances-0.1.11/build/Instances/TH/Lift.js_o )
Linking Template Haskell ()
Linking Template Haskell (ThRunner1)

Note the ThRunner1, it something which is not the most reliable piece, I think.

phadej commented 5 years ago

FWIW, I would advice not to build and upload docs with GHC-8.0 (or at all). Hackage's doc-builder is nowadays reliable.

The downside that e.g. Lift link links to template-haskell-2.10, which is old. Also Map etc. containers type links to old container release (the one bundled with GHC-8.0).

phadej commented 5 years ago

travis is finally satisfied

bennofs commented 5 years ago

Thank you a lot for fixing travis. I'll take a detailed look at this tomorrow and merge + release.

phadej commented 5 years ago

ping @bennofs

phadej commented 5 years ago

Thanks Benno.

After release I discovered a small mess I created: https://github.com/mboes/th-lift/pull/39 I'll make a follow up pull request once/if we get th-lift release. Sorry for inconvenience, but let's try to find good home for the orphans.